* [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup
@ 2010-03-14 13:19 Naphtali Sprei
2010-03-15 12:29 ` [Qemu-devel] " Paolo Bonzini
2010-03-17 16:59 ` [Qemu-devel] " Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Naphtali Sprei @ 2010-03-14 13:19 UTC (permalink / raw)
To: qemu-devel
Really use read-only flags for opening the file when asked for read-only
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
---
qemu-nbd.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index eac0c21..a393583 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -258,6 +258,7 @@ int main(int argc, char **argv)
break;
case 'r':
readonly = true;
+ flags &= ~BDRV_O_RDWR;
break;
case 'P':
partition = strtol(optarg, &end, 0);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH v2 1/2] read-only: minor cleanup
2010-03-14 13:19 [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup Naphtali Sprei
@ 2010-03-15 12:29 ` Paolo Bonzini
2010-03-17 16:59 ` [Qemu-devel] " Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2010-03-15 12:29 UTC (permalink / raw)
To: Naphtali Sprei; +Cc: qemu-devel
On 03/14/2010 02:19 PM, Naphtali Sprei wrote:
> Really use read-only flags for opening the file when asked for read-only
>
> Signed-off-by: Naphtali Sprei<nsprei@redhat.com>
> ---
> qemu-nbd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index eac0c21..a393583 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -258,6 +258,7 @@ int main(int argc, char **argv)
> break;
> case 'r':
> readonly = true;
> + flags&= ~BDRV_O_RDWR;
> break;
> case 'P':
> partition = strtol(optarg,&end, 0);
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup
2010-03-14 13:19 [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup Naphtali Sprei
2010-03-15 12:29 ` [Qemu-devel] " Paolo Bonzini
@ 2010-03-17 16:59 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-03-17 16:59 UTC (permalink / raw)
To: Naphtali Sprei; +Cc: qemu-devel
On 03/14/2010 08:19 AM, Naphtali Sprei wrote:
> Really use read-only flags for opening the file when asked for read-only
>
> Signed-off-by: Naphtali Sprei<nsprei@redhat.com>
>
Applied all. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-nbd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index eac0c21..a393583 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -258,6 +258,7 @@ int main(int argc, char **argv)
> break;
> case 'r':
> readonly = true;
> + flags&= ~BDRV_O_RDWR;
> break;
> case 'P':
> partition = strtol(optarg,&end, 0);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-17 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-14 13:19 [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup Naphtali Sprei
2010-03-15 12:29 ` [Qemu-devel] " Paolo Bonzini
2010-03-17 16:59 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).