From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NrF6U-00027O-LN
	for qemu-devel@nongnu.org; Mon, 15 Mar 2010 14:33:26 -0400
Received: from [199.232.76.173] (port=33105 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NrF6U-00026s-5R
	for qemu-devel@nongnu.org; Mon, 15 Mar 2010 14:33:26 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <pbonzini@redhat.com>) id 1NrF6T-0002VO-IU
	for qemu-devel@nongnu.org; Mon, 15 Mar 2010 14:33:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55018)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NrF6T-0002VE-5o
	for qemu-devel@nongnu.org; Mon, 15 Mar 2010 14:33:25 -0400
Message-ID: <4B9E7D6F.4000702@redhat.com>
Date: Mon, 15 Mar 2010 19:33:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <f43fc5581003130656j408f64bfp7fe4bf486c625624@mail.gmail.com>	
	<m3sk82nj16.fsf@blackfin.pond.sub.org>	
	<f43fc5581003151023g354dc74cr989f3373f5f1de9a@mail.gmail.com>	
	<4B9E7A29.1020902@redhat.com>
	<f43fc5581003151126m6a857c57vd16935b6f98a6f07@mail.gmail.com>
In-Reply-To: <f43fc5581003151126m6a857c57vd16935b6f98a6f07@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH,
	RFC] Replace assert(0) with abort() or cpu_abort()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

>> I'd consider not changing assert(0)->abort()
>> if there is code after the assert that looks like an attempt at recovering.
>> Example:
>>
>>     if (!p) {
>>         printf ("the impossible has happened!");
>>         assert (0);
>>     }
>>
>>     return p->q;
>>
>>   should be changed to abort, while
>>
>>     if (!p) {
>>         printf ("the impossible has happened!");
>>         assert (0);
>>         return 0;
>>     }
>>
>>     return p->q;
>>
>>   should not.
>
> Why not? According to manual page, assert(x) is equal to if (!x) abort().
> As I mentioned earlier, system emulators don't handle SIGABRT

... which won't be generated if !NDEBUG.  Only if the recovery code 
makes sense, of course.  However, my point was that those cases where 
there is recovery code are not no-brainers.

Paolo