From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrVrU-0002ub-JT for qemu-devel@nongnu.org; Tue, 16 Mar 2010 08:27:04 -0400 Received: from [199.232.76.173] (port=48432 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrVrU-0002uQ-4w for qemu-devel@nongnu.org; Tue, 16 Mar 2010 08:27:04 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrVrT-000489-K7 for qemu-devel@nongnu.org; Tue, 16 Mar 2010 08:27:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55889) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrVrT-000485-7d for qemu-devel@nongnu.org; Tue, 16 Mar 2010 08:27:03 -0400 Message-ID: <4B9F7909.8010904@redhat.com> Date: Tue, 16 Mar 2010 14:26:49 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1268736839-27371-2-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> In-Reply-To: <1268736839-27371-2-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org, kvm@vger.kernel.org On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: > Replaces byte-based phys_ram_dirty bitmap with > three bit-based phys_ram_dirty bitmap. > On allocation, it sets all bits in the bitmap. > > Signed-off-by: Yoshiaki Tamura > Signed-off-by: OHMURA Kei > --- > exec.c | 22 +++++++++++++++++----- > 1 files changed, 17 insertions(+), 5 deletions(-) > > diff --git a/exec.c b/exec.c > index 9bcb4de..ba334e7 100644 > --- a/exec.c > +++ b/exec.c > @@ -119,7 +119,9 @@ uint8_t *code_gen_ptr; > > #if !defined(CONFIG_USER_ONLY) > int phys_ram_fd; > -uint8_t *phys_ram_dirty; > +unsigned long *phys_ram_vga_dirty; > +unsigned long *phys_ram_code_dirty; > +unsigned long *phys_ram_migration_dirty; > Would be nice to make this an array. -- error compiling committee.c: too many arguments to function