qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH, RFC] Replace assert(0) with abort() or  cpu_abort()
Date: Wed, 17 Mar 2010 10:10:10 +0100	[thread overview]
Message-ID: <4BA09C72.9060201@redhat.com> (raw)
In-Reply-To: <20100316175523.GD19160@shareable.org>

On 03/16/2010 06:55 PM, Jamie Lokier wrote:
> A guest program is also allowed to trap SIGABRT with a signal handler,
> and that does have some uses.  E.g. cleaning up temporary files and
> shmem segments following a crash when calling 3rd party code.
>
> Whatever the guest does with SIGABRT, it should not result in_QEMU_
> crashing - whether due to abort() returning, or QEMU's control flow
> jumping to the guest's signal handler from an unexpected location.

That's very hard to ensure however if QEMU was already in unstable 
state, as witnessed by its call to abort().  Things can only go downhill.

Maybe there should be a qemu_abort wrapper (and a QEMU_ASSERT companion) 
that does simply abort/assert under system emulation, but under 
user-mode emulation does

   signal (SIGABRT, SIG_DFL);
   abort ();

Paolo

  reply	other threads:[~2010-03-17  9:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13 14:56 [Qemu-devel] [PATCH, RFC] Replace assert(0) with abort() or cpu_abort() Blue Swirl
2010-03-13 15:43 ` Edgar E. Iglesias
2010-03-15  7:25 ` Markus Armbruster
2010-03-15 17:23   ` Blue Swirl
2010-03-15 18:19     ` [Qemu-devel] " Paolo Bonzini
2010-03-15 18:26       ` Blue Swirl
2010-03-15 18:33         ` Paolo Bonzini
2010-03-15 19:02           ` Blue Swirl
2010-03-15 18:28       ` Markus Armbruster
2010-03-15 18:36     ` [Qemu-devel] " Markus Armbruster
2010-03-16  8:24       ` [Qemu-devel] " Paolo Bonzini
2010-03-16  8:54         ` Markus Armbruster
2010-03-16 17:55           ` Jamie Lokier
2010-03-17  9:10             ` Paolo Bonzini [this message]
2010-03-17 19:50               ` Blue Swirl
2010-03-19  2:03                 ` Jamie Lokier
2010-03-19 20:28                   ` Blue Swirl
2010-03-18  8:36             ` Markus Armbruster
2010-03-16 17:52         ` Jamie Lokier
2010-03-16 18:35           ` Markus Armbruster
     [not found] <1317337484.400521268903946714.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-03-18  9:19 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA09C72.9060201@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=jamie@shareable.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).