From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrwHb-0004qN-1J for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:39:47 -0400 Received: from [199.232.76.173] (port=43339 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrwHa-0004pW-BQ for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:39:46 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrwHX-0003jo-Ej for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:39:45 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:49148) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrwHW-0003jU-SU for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:39:43 -0400 Received: by pwi9 with SMTP id 9so869306pwi.4 for ; Wed, 17 Mar 2010 09:39:37 -0700 (PDT) Message-ID: <4BA105C7.6030806@codemonkey.ws> Date: Wed, 17 Mar 2010 11:39:35 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] [TRIVIAL] usb-linux: remove unreachable default in switch statement References: <1268053115.2130.4.camel@localhost.localdomain> <4BA0FC66.6080307@codemonkey.ws> <1268842456.2231.6.camel@localhost.localdomain> In-Reply-To: <1268842456.2231.6.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Bolle Cc: qemu-devel@nongnu.org, Paul Brook On 03/17/2010 11:14 AM, Paul Bolle wrote: > On Wed, 2010-03-17 at 10:59 -0500, Anthony Liguori wrote: > >> On 03/08/2010 06:58 AM, Paul Bolle wrote: >> >>> Signed-off-by: Paul Bolle >>> >>> >> Applied. Thanks. >> > Paul Brook was "tempted to replace it by an abort()" (about one and a > half week ago). Did you perhaps miss that message or weren't you tempted > to do this? > I missed it, but then again, I don't think the patch was wrong in the first place. I think we use too many aborts/exits in the device model that can potentially be triggered by guest code. Regards, Anthony Liguori > Regards, > > > Paul Bolle > >