From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NrwIT-0005we-QD
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:40:43 -0400
Received: from [199.232.76.173] (port=37734 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NrwIS-0005ux-5k
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:40:40 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NrwIQ-0003lh-Rl
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:40:39 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:56417)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NrwIQ-0003lV-0e
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 12:40:38 -0400
Received: by pvf33 with SMTP id 33so602473pvf.4
	for <qemu-devel@nongnu.org>; Wed, 17 Mar 2010 09:40:33 -0700 (PDT)
Message-ID: <4BA105FE.10503@codemonkey.ws>
Date: Wed, 17 Mar 2010 11:40:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] better describe -net options
References: <9cd4c8fc1003051307o5cf65642rd065d0da5f75c901@mail.gmail.com>
	<4BA0F601.4060802@codemonkey.ws>
	<20100317161316.GA19158@shareable.org>
In-Reply-To: <20100317161316.GA19158@shareable.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel@nongnu.org, Brian Thomason <brian.thomason@canonical.com>

On 03/17/2010 11:13 AM, Jamie Lokier wrote:
> Anthony Liguori wrote:
>    
>>     On 03/05/2010 03:07 PM, Brian Thomason wrote:
>>
>>       The manpage reflects that multiple -net user calls may be made,
>>       but if this is done, it can cause the program to hang. Instead,
>>       multiple -net calls can be combined into one, and this patch adds
>>       that information to qemu-options.hx. Also, -net user may only
>>       be used in conjunction with -net nic.  This is already implcitly
>>       stated, but this patch makes that statement more explicit.
>>
>>     Actually, the problem is that the user created a loop.  It's actually
>>     valid to have something like:
>>     -net user -net dump,file=foo.pcap -net nic
>>     But having -net user -net user creates a loop.
>>      
> When I used -net user -net user, it didn't hang: QEMU crashed with a
> stack overflow.
>
> It crashed after a doing a successful full OS install, because
> everything was fine until the first network packet.
>
> That's not nice, even if it is user error.
>    

Well we should dedicate this case in the code and throw an error.

Regards,

Anthony Liguori

> -- Jamie
>