qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: OHMURA Kei <ohmura.kei@lab.ntt.co.jp>
To: Juan Quintela <quintela@redhat.com>
Cc: ohmura.kei@lab.ntt.co.jp,
	Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: virtio_blk_load() question
Date: Thu, 18 Mar 2010 18:42:16 +0900	[thread overview]
Message-ID: <4BA1F578.4040500@lab.ntt.co.jp> (raw)
In-Reply-To: <m3hboenkr0.fsf@trasno.mitica>

Thanks for your reply.

> When I ported virtio to vmstate, I was unable to get that list not empty
> for more than I tried.  It should be not empty in the case of one error
> or similar, but I was not able to reproduce it.

Actually, I wasn't able to get that condition either.
We're having problem in loading continuously sent VM image, and were
looking deeper into the device models.  We were doubting the
virtio_blk_load() first, but seems to be different.

> I agree this change is ok/needed.  Notice that my series ( [PATCH 0/9]
> Virtio cleanups) that changes it to a QLIST and fixes it.

I guess you're mentioning the following patch, and it's good to know
that.

http://www.mail-archive.com/qemu-devel@nongnu.org/msg27324.html

However, although QLIST_INSERT_HEAD is used, virtio_blk_save() is
adding requests to the tail of the list, and if we need to keep the
order of outstading requests, shouldn't we put incoming requests to
the tail in virtio_blk_load()?

  reply	other threads:[~2010-03-18  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18  4:30 [Qemu-devel] virtio_blk_load() question OHMURA Kei
2010-03-18  7:37 ` [Qemu-devel] " Juan Quintela
2010-03-18  9:42   ` OHMURA Kei [this message]
2010-03-18 12:07     ` Juan Quintela
2010-03-19  2:53       ` OHMURA Kei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA1F578.4040500@lab.ntt.co.jp \
    --to=ohmura.kei@lab.ntt.co.jp \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=tamura.yoshiaki@lab.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).