Re: [Qemu-devel] build error in current master

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/21/2010 02:37 PM, Blue Swirl wrote:
> On 3/21/10, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 03/20/2010 03:14 AM, Blue Swirl wrote:
>>
>>      
>>> On 3/20/10, Paul Bolle<pebolle@tiscali.nl>   wrote:
>>>
>>>
>>>        
>>>> 0) Building current master
>>>>          
>> (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a,
>>      
>>>>   Introduce a default qmp session) fails here:
>>>>
>>>>   $ make>   /dev/null
>>>>   cc1: warnings being treated as errors
>>>>   curses.c: In function ‘curses_display_init’:
>>>>   curses.c:341: error: initialization from incompatible pointer type
>>>>   make: *** [curses.o] Error 1
>>>>
>>>>   1) It seems caused by commit d7234f4d (committed half a day ago):
>>>>
>>>>   $ git blame curses.c | grep 341
>>>>   d7234f4d (Anthony Liguori 2010-03-17 17:59:26 -0500 341)     static
>>>>   Notifier notifier = { .notify = curses_atexit };
>>>>
>>>>   $ git log -1 d7234f4d  --pretty=short
>>>>   commit d7234f4d7e373a708e1df9ab565a71b71b189025
>>>>   Author: Anthony Liguori<aliguori@us.ibm.com>
>>>>
>>>>      Convert atexit users to exit_notifier
>>>>
>>>>   Regards,
>>>>
>>>>
>>>>          
>>>   Fixed in HEAD.
>>>
>>>
>>>        
>>   I've reverted a bunch of these commits.  They're still a work-in-progress.
>> Looks like I pushed the wrong branch.
>>      
> Maybe you shouldn't have reverted:
>    CC    curses.o
> cc1: warnings being treated as errors
> /src/qemu/curses.c: In function 'curses_display_init':
> /src/qemu/curses.c:345: error: passing argument 1 of 'atexit' from
> incompatible pointer type
>    

Sorry, new laptop and I didn't have curses-devel installed yet :-/

Regards,

Anthony Liguori