From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NtUbP-00014z-69
	for qemu-devel@nongnu.org; Sun, 21 Mar 2010 19:30:39 -0400
Received: from [199.232.76.173] (port=45005 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NtUbO-00014r-MG
	for qemu-devel@nongnu.org; Sun, 21 Mar 2010 19:30:38 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <anthony@codemonkey.ws>) id 1NtUbL-0001dC-GG
	for qemu-devel@nongnu.org; Sun, 21 Mar 2010 19:30:38 -0400
Received: from mail-gw0-f45.google.com ([74.125.83.45]:58803)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NtUbL-0001d8-8s
	for qemu-devel@nongnu.org; Sun, 21 Mar 2010 19:30:35 -0400
Received: by gwb11 with SMTP id 11so1152224gwb.4
	for <qemu-devel@nongnu.org>; Sun, 21 Mar 2010 16:30:34 -0700 (PDT)
Message-ID: <4BA6AC17.4080107@codemonkey.ws>
Date: Sun, 21 Mar 2010 18:30:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] build error in current master
References: <1269071241.1725.8.camel@localhost.localdomain>	
	<f43fc5581003200114q34510a82g92dd6bbe4e6aeb14@mail.gmail.com>	
	<4BA670B5.6010704@codemonkey.ws>
	<f43fc5581003211237w40c9628fvf443cce310031140@mail.gmail.com>
In-Reply-To: <f43fc5581003211237w40c9628fvf443cce310031140@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paul Bolle <pebolle@tiscali.nl>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 03/21/2010 02:37 PM, Blue Swirl wrote:
> On 3/21/10, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 03/20/2010 03:14 AM, Blue Swirl wrote:
>>
>>      
>>> On 3/20/10, Paul Bolle<pebolle@tiscali.nl>   wrote:
>>>
>>>
>>>        
>>>> 0) Building current master
>>>>          
>> (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a,
>>      
>>>>   Introduce a default qmp session) fails here:
>>>>
>>>>   $ make>   /dev/null
>>>>   cc1: warnings being treated as errors
>>>>   curses.c: In function ‘curses_display_init’:
>>>>   curses.c:341: error: initialization from incompatible pointer type
>>>>   make: *** [curses.o] Error 1
>>>>
>>>>   1) It seems caused by commit d7234f4d (committed half a day ago):
>>>>
>>>>   $ git blame curses.c | grep 341
>>>>   d7234f4d (Anthony Liguori 2010-03-17 17:59:26 -0500 341)     static
>>>>   Notifier notifier = { .notify = curses_atexit };
>>>>
>>>>   $ git log -1 d7234f4d  --pretty=short
>>>>   commit d7234f4d7e373a708e1df9ab565a71b71b189025
>>>>   Author: Anthony Liguori<aliguori@us.ibm.com>
>>>>
>>>>      Convert atexit users to exit_notifier
>>>>
>>>>   Regards,
>>>>
>>>>
>>>>          
>>>   Fixed in HEAD.
>>>
>>>
>>>        
>>   I've reverted a bunch of these commits.  They're still a work-in-progress.
>> Looks like I pushed the wrong branch.
>>      
> Maybe you shouldn't have reverted:
>    CC    curses.o
> cc1: warnings being treated as errors
> /src/qemu/curses.c: In function 'curses_display_init':
> /src/qemu/curses.c:345: error: passing argument 1 of 'atexit' from
> incompatible pointer type
>    

Sorry, new laptop and I didn't have curses-devel installed yet :-/

Regards,

Anthony Liguori