qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Bruce Majia <bruce.majia@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Build always fail on x86_32 host for i386_softmmu target
Date: Mon, 22 Mar 2010 09:31:09 +0100	[thread overview]
Message-ID: <4BA72ACD.8030008@mail.berlios.de> (raw)
In-Reply-To: <20100322061658.GC20376@localhost>

Bruce Majia schrieb:
> Hi,
>
> When I built qemu on my x86_32 host with following configure line:
>
> $ ./configure --prefix=/usr/local/qemus/master \
> --target-list=i386-softmmu
> $ make
>
> The build will always fail with message:
> ----------------------------------------
> ...
> CC i386-softmmu/fpu/softfloat-native.o
> /mnt/farm/my_repo/qemu/fpu/softfloat-native.c:130:5: error:
> "HOST_LONG_BITS" is not defined
> make[1]: *** [fpu/softfloat-native.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
> ----------------------------------------
>
> Is this a known issue or something wrong with my configure line?
>
> Though I can make it work with a minor nasty patch:
> ==============
> diff --git a/fpu/softfloat-native.c b/fpu/softfloat-native.c
> index 049c830..5ba5013 100644
> --- a/fpu/softfloat-native.c
> +++ b/fpu/softfloat-native.c
> @@ -127,6 +127,9 @@ floatx80 int64_to_floatx80( int64_t v STATUS_PARAM)
> #endif
>
> /* XXX: this code implements the x86 behaviour, not the IEEE one. */
> +#ifndef HOST_LONG_BITS
> +#define HOST_LONG_BITS 32
> +#endif
> #if HOST_LONG_BITS == 32
> static inline int long_to_int32(long a)
> {
> ==============
>
> I thought it may necessary to ask if something wrong with above hack.
> And can we get the problem fixed properly?
>
> Thanks.
> -b

I had this problem with incremental builds several times, too.
A new make from scratch (all generated files removed) always worked,
so I don't think your patch is needed.

Regards,
Stefan

  reply	other threads:[~2010-03-22  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22  6:16 [Qemu-devel] Build always fail on x86_32 host for i386_softmmu target Bruce Majia
2010-03-22  8:31 ` Stefan Weil [this message]
2010-03-22  8:36   ` Bruce Majia
2010-03-22  8:50 ` [Qemu-devel] " Juan Quintela
2010-03-22 13:44   ` Jan Kiszka
2010-03-22 13:49     ` Juan Quintela
2010-03-22 13:57       ` Jan Kiszka
2010-03-22 14:05         ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA72ACD.8030008@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=bruce.majia@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).