From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ntkgr-0006XP-Tg for qemu-devel@nongnu.org; Mon, 22 Mar 2010 12:41:21 -0400 Received: from [199.232.76.173] (port=43865 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ntkgq-0006XB-QV for qemu-devel@nongnu.org; Mon, 22 Mar 2010 12:41:20 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ntkgn-0005ms-Do for qemu-devel@nongnu.org; Mon, 22 Mar 2010 12:41:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38179) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ntkgm-0005mg-CK for qemu-devel@nongnu.org; Mon, 22 Mar 2010 12:41:16 -0400 Message-ID: <4BA79BDD.7020303@redhat.com> Date: Mon, 22 Mar 2010 12:33:33 -0400 From: john cooper MIME-Version: 1.0 Subject: Re: [Qemu-devel] virtio block device and sysfs References: <20100322162441.GA5727@shareable.org> In-Reply-To: <20100322162441.GA5727@shareable.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: john.cooper@redhat.com, Marc Haber , qemu-devel@nongnu.org Jamie Lokier wrote: > john cooper wrote: >> All that said, I like the alternate choice of adding a >> special virtio request far better. It is actually simpler >> (and more maintainable IMO) than going through the >> gyrations of stuffing the S/N data through PCI config >> space. > > And it needn't have a 20 character limit. Technically yes it can be longer. Although IIRC the 20/21 byte assumption is fairly entrenched in related code. It may also be encouraged if the ATA interface is used to expose the data (under windows for instance). -john -- john.cooper@redhat.com