From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NtnTT-0006ze-KT for qemu-devel@nongnu.org; Mon, 22 Mar 2010 15:39:43 -0400 Received: from [199.232.76.173] (port=43432 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NtnTS-0006zW-At for qemu-devel@nongnu.org; Mon, 22 Mar 2010 15:39:42 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NtnTQ-0005T3-Ue for qemu-devel@nongnu.org; Mon, 22 Mar 2010 15:39:42 -0400 Received: from fg-out-1718.google.com ([72.14.220.159]:14851) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NtnTQ-0005Su-IU for qemu-devel@nongnu.org; Mon, 22 Mar 2010 15:39:40 -0400 Received: by fg-out-1718.google.com with SMTP id l26so587794fgb.10 for ; Mon, 22 Mar 2010 12:39:38 -0700 (PDT) Message-ID: <4BA7C773.1050401@codemonkey.ws> Date: Mon, 22 Mar 2010 14:39:31 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers References: <4B98FA68.7000901@codemonkey.ws> <1268318923-13397-1-git-send-email-avi@redhat.com> In-Reply-To: <1268318923-13397-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On 03/11/2010 08:48 AM, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > CODING_STYLE | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index a579cb1..92036f3 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -49,6 +49,9 @@ and is therefore likely to be changed. > Typedefs are used to eliminate the redundant 'struct' keyword. It is the > QEMU coding style. > > +When wrapping standard library functions, use the prefix qemu_ to alert > +readers that they are seeing a wrapped version; otherwise avoid this prefix. > + > 4. Block structure > > Every indented statement is braced; even if the block contains just one > Applied. Thanks. Regards, Anthony Liguori