From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuIaj-0001I3-Td for qemu-devel@nongnu.org; Wed, 24 Mar 2010 00:53:17 -0400 Received: from [140.186.70.92] (port=54481 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuIag-0001CD-PR for qemu-devel@nongnu.org; Wed, 24 Mar 2010 00:53:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuIaf-0007wq-Bm for qemu-devel@nongnu.org; Wed, 24 Mar 2010 00:53:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64647) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuIae-0007wi-Ig for qemu-devel@nongnu.org; Wed, 24 Mar 2010 00:53:13 -0400 Message-ID: <4BA99AAE.5040702@redhat.com> Date: Wed, 24 Mar 2010 06:53:02 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Supporting hypervisor specific APIs in libvirt References: <4BA7C40C.2040505@codemonkey.ws> <4BA900F1.5020001@redhat.com> <4BA916FC.2000607@codemonkey.ws> In-Reply-To: <4BA916FC.2000607@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "libvir-list@redhat.com" , qemu-devel On 03/23/2010 09:31 PM, Anthony Liguori wrote: > >> >> One problem is that this is libvirt version specific. For example, >> libvirt x doesn't support spice so we control that thorough qmp. But >> libvirt x+1 does support spice and now it gets confused about all the >> spice messages. > > That's only a problem if we only support a single QMP session. This > is exactly why we need to support multiple QMP sessions (and do). It's unrelated to the number of sessions. libvirt expects state that it manages in qemu not to change randomly. Users know that, so they will only manage non-libvirt state in their private session. But a new version of libvirt may expand its scope and start managing this area, leading to conflicts. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.