From: Alexander Graf <agraf@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci
Date: Wed, 24 Mar 2010 19:24:03 +0100 [thread overview]
Message-ID: <4BAA58C3.7040006@suse.de> (raw)
In-Reply-To: <f43fc5581003241122o7561bbbfp8b14904c40ac615f@mail.gmail.com>
Blue Swirl wrote:
> On 3/24/10, Alexander Graf <agraf@suse.de> wrote:
>
>> As soon as virtio-pci.c gets compiled and used on S390 the internal qdev magic
>> gets confused and tries to give us PCI devices instead of S390 virtio devices.
>>
>> Since we don't have PCI on S390, we can safely not compile virtio-pci at all.
>>
>> In order to do this I added a new config option "CONFIG_PCI" that I enabled
>> for every platform except S390. Thanks to this the change should be a complete
>> nop for every other platform.
>>
>
> The name should be CONFIG_VIRTIO_PCI, CONFIG_PCI would enable
> compilation of pci.c.
>
My idea was to keep the config option generic and rip out all PCI stuff
from s390x-softmmu. We don't even do MMIO :-).
Alex
next prev parent reply other threads:[~2010-03-24 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:30 [Qemu-devel] [PATCH 0/3] Fix S390x target Alexander Graf
2010-03-24 17:30 ` [Qemu-devel] [PATCH 1/3] S390: Add stub for cpu_get_phys_page_debug Alexander Graf
2010-03-24 17:30 ` [Qemu-devel] [PATCH 2/3] S390: Tell user why VM creation failed Alexander Graf
2010-03-24 17:30 ` [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci Alexander Graf
2010-03-24 18:22 ` Blue Swirl
2010-03-24 18:24 ` Alexander Graf [this message]
2010-03-24 19:17 ` Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2010-03-25 13:58 [Qemu-devel] [PATCH 0/3] Fix S390x target v2 Alexander Graf
2010-03-25 13:59 ` [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAA58C3.7040006@suse.de \
--to=agraf@suse.de \
--cc=blauwirbel@gmail.com \
--cc=cotte@de.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).