From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuVFS-0007ck-1A for qemu-devel@nongnu.org; Wed, 24 Mar 2010 14:24:10 -0400 Received: from [140.186.70.92] (port=49477 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuVFQ-0007cb-Sm for qemu-devel@nongnu.org; Wed, 24 Mar 2010 14:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuVFN-00080Y-V9 for qemu-devel@nongnu.org; Wed, 24 Mar 2010 14:24:08 -0400 Received: from cantor.suse.de ([195.135.220.2]:35200 helo=mx1.suse.de) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuVFN-00080K-Mo for qemu-devel@nongnu.org; Wed, 24 Mar 2010 14:24:05 -0400 Message-ID: <4BAA58C3.7040006@suse.de> Date: Wed, 24 Mar 2010 19:24:03 +0100 From: Alexander Graf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/3] S390: Don't compile in virtio-pci References: <1269451840-13941-1-git-send-email-agraf@suse.de> <1269451840-13941-4-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Carsten Otte , qemu-devel@nongnu.org Blue Swirl wrote: > On 3/24/10, Alexander Graf wrote: > >> As soon as virtio-pci.c gets compiled and used on S390 the internal qdev magic >> gets confused and tries to give us PCI devices instead of S390 virtio devices. >> >> Since we don't have PCI on S390, we can safely not compile virtio-pci at all. >> >> In order to do this I added a new config option "CONFIG_PCI" that I enabled >> for every platform except S390. Thanks to this the change should be a complete >> nop for every other platform. >> > > The name should be CONFIG_VIRTIO_PCI, CONFIG_PCI would enable > compilation of pci.c. > My idea was to keep the config option generic and rip out all PCI stuff from s390x-softmmu. We don't even do MMIO :-). Alex