From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuWVA-00022X-Qy
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:44:28 -0400
Received: from [140.186.70.92] (port=36051 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuWV8-00022G-Q7
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:44:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1NuWV6-0001Nj-Hr
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:44:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57917)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1NuWV6-0001NX-AV
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:44:24 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OJiNk9000775
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 24 Mar 2010 15:44:23 -0400
Message-ID: <4BAA6B93.1090405@redhat.com>
Date: Wed, 24 Mar 2010 20:44:19 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1269440070-26788-1-git-send-email-kraxel@redhat.com>
	<m3pr2t8xdq.fsf@trasno.mitica>
In-Reply-To: <m3pr2t8xdq.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] update bochs vbe interface
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On 03/24/10 18:04, Juan Quintela wrote:
> Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> The bochs vbe interface got a new register a while back, which specifies
>> the linear framebuffer size in 64k units.  This patch adds support for
>> the new register to qemu.  With this patch applied vgabios 0.6c works
>> with qemu.
>>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>
> It breaks migration.
>
> vga.c:2218:        VMSTATE_UINT16_ARRAY(vbe_regs, VGACommonState, VBE_DISPI_INDEX_NB),

> 2218 is the interesting line.  Can we freeze this patch until the
> subsections stuff is done?

Yea, I see.  Well, the new register doesn't carry any state, it is 
read-only information for the guest.  So the easy way out is to simply 
not save it as we don't have to.

cheers,
   Gerd