From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nupyv-0007MF-Fk for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:32:29 -0400 Received: from [140.186.70.92] (port=48805 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nupyt-0007KX-Sb for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:32:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nupys-0003Kt-BV for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:32:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2962) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nupys-0003KY-3Y for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:32:26 -0400 Message-ID: <4BAB900F.5030104@redhat.com> Date: Thu, 25 Mar 2010 18:32:15 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1269497376-21903-1-git-send-email-cam@cs.ualberta.ca> <20100325091552.GB11153@redhat.com> <8286e4ee1003250918x659e87ai9e5ca7c68c23a7c3@mail.gmail.com> <4BAB8DE9.9080603@codemonkey.ws> In-Reply-To: <4BAB8DE9.9080603@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Cam Macdonell , virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" On 03/25/2010 06:23 PM, Anthony Liguori wrote: >> There has been previous discussion of virtio, however while virtio is >> good for exporting guest memory, it's not ideal for importing memory >> into a guest. > > virtio is a DMA-based API which means that it doesn't assume cache > coherent shared memory. The PCI transport takes advantage of cache > coherent shared memory but it's not strictly required. Aren't we violating this by not using dma_alloc_coherent() for the queues? -- error compiling committee.c: too many arguments to function