From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuqV5-0005Ry-MH for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:05:43 -0400 Received: from [140.186.70.92] (port=33295 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuqV3-0004vH-GU for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:05:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuqGv-0006Ip-8z for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:51:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45054) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuqGu-0006Ik-UB for qemu-devel@nongnu.org; Thu, 25 Mar 2010 12:51:05 -0400 Message-ID: <4BAB9475.9000703@redhat.com> Date: Thu, 25 Mar 2010 18:51:01 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1269497376-21903-1-git-send-email-cam@cs.ualberta.ca> <20100325090513.GA11153@redhat.com> <4BAB90F2.6030706@redhat.com> <20100325163729.GA16506@redhat.com> In-Reply-To: <20100325163729.GA16506@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 1/1] Shared memory uio_pci driver List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Cam Macdonell , qemu-devel@nongnu.org, kvm@vger.kernel.org On 03/25/2010 06:37 PM, Michael S. Tsirkin wrote: > On Thu, Mar 25, 2010 at 06:36:02PM +0200, Avi Kivity wrote: > >> On 03/25/2010 11:05 AM, Michael S. Tsirkin wrote: >> >>> >>>> +static struct pci_device_id ivshmem_pci_ids[] __devinitdata = { >>>> + { >>>> + .vendor = 0x1af4, >>>> + .device = 0x1110, >>>> >>>> >>> vendor ids must be registered with PCI SIG. >>> this one does not seem to be registered. >>> >>> >> That's the Qumranet vendor ID. >> > Isn't virtio_pci matching that id already? > > virtio matches devices 1000-1100 or something. -- error compiling committee.c: too many arguments to function