From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NvC5X-0004A4-CT
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:08:47 -0400
Received: from [140.186.70.92] (port=41662 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NvC5I-0003fk-JR
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:08:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1NvC4N-000707-5W
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:08:20 -0400
Received: from are.twiddle.net ([75.149.56.221]:47047)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <rth@twiddle.net>) id 1NvC4M-0006zm-Uw
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:07:35 -0400
Message-ID: <4BACDBC4.2060501@twiddle.net>
Date: Fri, 26 Mar 2010 09:07:32 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/4] fix 0 sized write syscall
References: <cover.1269616764.git.riku.voipio@nokia.com>	<f006b92f2656f50808bcb4d7ede5580b1a7ca01a.1269616764.git.riku.voipio@nokia.com>	<24d55bf05f43067a28600e3d2dba8c2a2c6ee76d.1269616764.git.riku.voipio@nokia.com>	<47b7d8a4c69443f7902c4b413143cb8de67c1d6e.1269616764.git.riku.voipio@nokia.com>
	<52e932ccb17304f60def454d2154726c972bacb6.1269616764.git.riku.voipio@nokia.com>
In-Reply-To: <52e932ccb17304f60def454d2154726c972bacb6.1269616764.git.riku.voipio@nokia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: martin.mohring@opensuse.org, Riku Voipio <riku.voipio@nokia.com>, qemu-devel@nongnu.org

On 03/26/2010 08:25 AM, Riku Voipio wrote:
> +    if (len == 0) {
> +        return 0;
> +    }

This part is ok.

>  
> -    if (start + len - 1 < start) {
> +    if (start + len < start) {

This part re-introduces the bug I fixed.

  start = 0xffffff00
  len = 256

should succeed, and it won't reverting the (len-1) change.


r~