From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvCkw-0005hM-PA for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:51:34 -0400 Received: from [140.186.70.92] (port=39700 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvCkv-0005h4-6y for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvCkr-0005fn-L1 for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:51:32 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:54430) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvCkr-0005fg-IO for qemu-devel@nongnu.org; Fri, 26 Mar 2010 12:51:29 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e8.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o2QGgn55012067 for ; Fri, 26 Mar 2010 12:42:49 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o2QGpSb8090672 for ; Fri, 26 Mar 2010 12:51:28 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o2QGpSYT025040 for ; Fri, 26 Mar 2010 12:51:28 -0400 Message-ID: <4BACE60D.6080904@linux.vnet.ibm.com> Date: Fri, 26 Mar 2010 11:51:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add References: <1269442173-18421-5-git-send-email-amit.shah@redhat.com> <1269442173-18421-6-git-send-email-amit.shah@redhat.com> <1269442173-18421-7-git-send-email-amit.shah@redhat.com> <1269442173-18421-8-git-send-email-amit.shah@redhat.com> <1269442173-18421-9-git-send-email-amit.shah@redhat.com> <1269442173-18421-10-git-send-email-amit.shah@redhat.com> <1269442173-18421-11-git-send-email-amit.shah@redhat.com> <20100325155541.570f817d@redhat.com> <20100326021628.GI8111@amit-x200.redhat.com> <20100326101402.02e3fffb@redhat.com> <20100326132620.GE7039@amit-x200.redhat.com> <20100326112903.712262b9@redhat.com> In-Reply-To: <20100326112903.712262b9@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , "Michael S. Tsirkin" , Juan Quintela , qemu list , Gerd Hoffmann , Amit Shah On 03/26/2010 09:29 AM, Luiz Capitulino wrote: > On Fri, 26 Mar 2010 18:56:20 +0530 > Amit Shah wrote: > > >> On (Fri) Mar 26 2010 [10:14:02], Luiz Capitulino wrote: >> >>>>>> + >>>>>> +VIRTIO_SERIAL >>>>>> +------------- >>>>>> >>>>> It should be VIRTIO_SERIAL_ADD. >>>>> >>>> What about other events that VIRTIO_SERIAL generates? >>>> >>> We don't address this problem currently, maybe an integration with qdev >>> will do, but I have to think more about it. >>> >> So should I just keep it as VIRTIO_SERIAL for now? With new events also >> riding on this one? >> > I don't like this because with the current events code this will lead > to confusion, as you're using a single event to notify different things. > > My suggestion for the immediate term is to do what we have been doing so > far, ie. call it VIRTIO_SERIAL_ADD. Worst case here is: we add a new way > to group events which requires a new VIRTIO_SERIAL event, in this case we > could emit both, the new VIRTIO_SERIAL and the old VIRTIO_SERIAL_ADD. The > latter would be deprecated too. > > Or, if you can wait I can _try_ to solve this problem next week, although > I have no idea how hard this is going to be. > > Any comments, Anthony? > The virtio serial events bother me in a number of ways. Ports being added should just be more generic (we should generate an event any time a device is added to a bus). Port disconnected/reconnect ought to be something that we propagate via a char device but I understand the limitations of the current code. I'd like to see us try to at least address the add/remove case better and we may just have to live with the connect/disconnect stuff. Regards, Anthony Liguori