* [Qemu-devel] [PATCH] Fix busted driftfix option
@ 2010-03-26 20:21 Zachary Amsden
2010-03-27 9:14 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Zachary Amsden @ 2010-03-26 20:21 UTC (permalink / raw)
To: QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 93 bytes --]
For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
the code is dead.
[-- Attachment #2: config-taget.patch --]
[-- Type: text/plain, Size: 408 bytes --]
CONFIG_TARGET_XXX is wrong
Signed-off-by: Zachary Amsden <zamsden@redhat.com>
diff --git a/vl.c b/vl.c
index 6e35cc6..9720619 100644
--- a/vl.c
+++ b/vl.c
@@ -1565,7 +1565,7 @@ static void configure_rtc(QemuOpts *opts)
exit(1);
}
}
-#ifdef CONFIG_TARGET_I386
+#ifdef TARGET_I386
value = qemu_opt_get(opts, "driftfix");
if (value) {
if (!strcmp(buf, "slew")) {
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix busted driftfix option
2010-03-26 20:21 [Qemu-devel] [PATCH] Fix busted driftfix option Zachary Amsden
@ 2010-03-27 9:14 ` Blue Swirl
2010-03-30 18:43 ` Zachary Amsden
0 siblings, 1 reply; 4+ messages in thread
From: Blue Swirl @ 2010-03-27 9:14 UTC (permalink / raw)
To: Zachary Amsden; +Cc: QEMU Developers
On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
> the code is dead.
The code is also broken: it references undefined variable 'buf'
instead of 'value'.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix busted driftfix option
2010-03-30 18:43 ` Zachary Amsden
@ 2010-03-29 18:48 ` Blue Swirl
0 siblings, 0 replies; 4+ messages in thread
From: Blue Swirl @ 2010-03-29 18:48 UTC (permalink / raw)
To: Zachary Amsden; +Cc: QEMU Developers
On 3/30/10, Zachary Amsden <zamsden@redhat.com> wrote:
> On 03/26/10 23:14, Blue Swirl wrote:
> > On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
> >
> >> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
> >> the code is dead.
> >>
> > The code is also broken: it references undefined variable 'buf'
> > instead of 'value'.
> >
>
>
> Sorry, that wasn't the case on the branch I ported from. Can you apply
> a trivial fix or should I send along a patch?
I've already committed the fix.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix busted driftfix option
2010-03-27 9:14 ` Blue Swirl
@ 2010-03-30 18:43 ` Zachary Amsden
2010-03-29 18:48 ` Blue Swirl
0 siblings, 1 reply; 4+ messages in thread
From: Zachary Amsden @ 2010-03-30 18:43 UTC (permalink / raw)
To: Blue Swirl; +Cc: QEMU Developers
On 03/26/10 23:14, Blue Swirl wrote:
> On 3/26/10, Zachary Amsden <zamsden@redhat.com> wrote:
>
>> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so
>> the code is dead.
>>
> The code is also broken: it references undefined variable 'buf'
> instead of 'value'.
>
Sorry, that wasn't the case on the branch I ported from. Can you apply
a trivial fix or should I send along a patch?
Thanks,
Zach
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-29 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 20:21 [Qemu-devel] [PATCH] Fix busted driftfix option Zachary Amsden
2010-03-27 9:14 ` Blue Swirl
2010-03-30 18:43 ` Zachary Amsden
2010-03-29 18:48 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).