From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwFwK-0000d7-5B for qemu-devel@nongnu.org; Mon, 29 Mar 2010 10:27:40 -0400 Received: from [140.186.70.92] (port=37244 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwFwI-0000cv-Pl for qemu-devel@nongnu.org; Mon, 29 Mar 2010 10:27:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwFwF-0007WH-70 for qemu-devel@nongnu.org; Mon, 29 Mar 2010 10:27:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15304) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwFwE-0007WA-W5 for qemu-devel@nongnu.org; Mon, 29 Mar 2010 10:27:35 -0400 Message-ID: <4BB0B8CE.6080301@redhat.com> Date: Mon, 29 Mar 2010 16:27:26 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] QEMU 0.12.3 and SCSI boot References: <4BB0A359.8010700@redhat.com> <4BB0AE15.6020303@redhat.com> <4BB0B064.6000007@redhat.com> In-Reply-To: <4BB0B064.6000007@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Gerhard Wiesinger , qemu-devel@nongnu.org On 03/29/10 15:51, Kevin Wolf wrote: >> It actually searches the queue in case tag != s->current->tag, and it >> should most likely do the same for s->current == NULL ... >> >> Attached patch makes the rom boot for me. > > Yes, works for me. And it seems to work reliably, unlike the 0.12.x > version. Oh. The lsi cleanup patches where supposed to be a no-op. Looks like I fixed bugs by accident ;) Seriously: Could be that stable code silently does something wong when reaching the point where master segfaults due to the NULL pointer dereference. > Maybe we should include the lsi patches in stable-0.12? Probably much easier than brewing a different version of the fix for 0.12. cheers Gerd