From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwJxW-0003Zw-IY for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:45:10 -0400 Received: from [140.186.70.92] (port=47080 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwJxU-0003Z7-Sw for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwJxP-0004Mf-TK for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:45:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51291) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwJxP-0004Lw-MJ for qemu-devel@nongnu.org; Mon, 29 Mar 2010 14:45:03 -0400 Message-ID: <4BB2465B.9040209@redhat.com> Date: Tue, 30 Mar 2010 08:43:39 -1000 From: Zachary Amsden MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix busted driftfix option References: <4BAD1763.4040602@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: QEMU Developers On 03/26/10 23:14, Blue Swirl wrote: > On 3/26/10, Zachary Amsden wrote: > >> For some reason, this uses CONFIG_TARGET_I386 instead of TARGET_I386, so >> the code is dead. >> > The code is also broken: it references undefined variable 'buf' > instead of 'value'. > Sorry, that wasn't the case on the branch I ported from. Can you apply a trivial fix or should I send along a patch? Thanks, Zach