From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nwqdy-0000Ja-Sw for qemu-devel@nongnu.org; Wed, 31 Mar 2010 01:39:10 -0400 Received: from [140.186.70.92] (port=39781 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwqdr-0000Ho-Jk for qemu-devel@nongnu.org; Wed, 31 Mar 2010 01:39:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nwqdp-0001Vm-Qv for qemu-devel@nongnu.org; Wed, 31 Mar 2010 01:39:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1139) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwqdp-0001Vb-JP for qemu-devel@nongnu.org; Wed, 31 Mar 2010 01:39:01 -0400 Message-ID: <4BB2DFE3.50607@redhat.com> Date: Wed, 31 Mar 2010 08:38:43 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20100330194056.GB24846@8bytes.org> In-Reply-To: <20100330194056.GB24846@8bytes.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joerg Roedel Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduard - Gabriel Munteanu On 03/30/2010 10:40 PM, Joerg Roedel wrote: > >> In short, this demonstrates a mechanism of inserting ACPI tables without >> modifying SeaBIOS or other BIOS implementations. I also have a SeaBIOS >> equivalent, but I think this approach is better, at least at the moment. >> > I like the approach implemented in this patchset because of its > simplicity. The right place for building acpi tables is the bios, > though. I am fine with both ways. Anthony, Avi, what do you > think about it? > I agree. Let qemu emulate the hardware, build the tables in the BIOS. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.