From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NwsLC-0003kN-KT
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:27:54 -0400
Received: from [140.186.70.92] (port=49509 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NwsLA-0003jv-FS
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:27:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1NwsL6-0005m0-KV
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:27:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:24645)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1NwsL6-0005lZ-Bh
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:27:48 -0400
Message-ID: <4BB2F958.50708@redhat.com>
Date: Wed, 31 Mar 2010 09:27:20 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c
References: <cover.1269936879.git.eduard.munteanu@linux360.ro>	
	<d9001abc473c4c13180637d00643cbafc587e13a.1269936879.git.eduard.munteanu@linux360.ro>
	<f43fc5581003301006o450c6de9rbb591f1b15729d36@mail.gmail.com>
In-Reply-To: <f43fc5581003301006o450c6de9rbb591f1b15729d36@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, joro@8bytes.org, qemu-devel@nongnu.org, avi@redhat.com, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>

On 03/30/10 19:06, Blue Swirl wrote:
> On 3/30/10, Eduard - Gabriel Munteanu<eduard.munteanu@linux360.ro>  wrote:
>> hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the
>>   AMD IOMMU, which could lead to confusion unless we rename the former.
>
> I was also thinking of renaming the file some time ago. The correct
> name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a
> different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had
> several IO-UNITs instead. All Sun4m machines had an IOMMU.
>
> But the qdev name of the device is still "iommu" and we can't change
> that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside
> in amd_iommu.c?

I'd go for the (filename) rename.  The qdev name shouldn't cause 
conflicts due to the different targets.

cheers,
   Gerd