From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nwxpf-00007e-RC
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:19:44 -0400
Received: from [140.186.70.92] (port=49237 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nwxpd-0008PB-T8
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:19:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Nwxjj-00034W-UY
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:13:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:1026)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Nwxjj-00034H-A9
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:13:35 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VDDVV4026124
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 31 Mar 2010 09:13:31 -0400
Message-ID: <4BB34A58.8040106@redhat.com>
Date: Wed, 31 Mar 2010 15:12:56 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1270039576-11968-1-git-send-email-kwolf@redhat.com>
	<m3r5n04p1o.fsf@trasno.mitica>
In-Reply-To: <m3r5n04p1o.fsf@trasno.mitica>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Replace calls of old bdrv_open
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

Am 31.03.2010 15:08, schrieb Juan Quintela:
> Kevin Wolf <kwolf@redhat.com> wrote:
>> What is known today as bdrv_open2 becomes the new bdrv_open. All remaining
>> callers of the old function are converted to the new one. In some places they
>> even know the right format, so they should have used bdrv_open2 from the
>> beginning.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> 
> I would preffer a:
> bdrv_open() like yours with assert(drv != NULL).
> 
> bdrv_open_guess() for the current behaviour with NULL drv argument.
> (name sucks but I can guet a better one at the momment).
> 
> Why?  because I would like to have an easy way to grep for all places
> that "guess" what driver should they use.  And as you found on the
> patch, several places knew it and where using it out of laziness.
> 
> If I can have my pony, your patch is better than current behaviour :)

Feel free to post a v2 that implements your version. :-)

Kevin