* [Qemu-devel] [PATCH] Restore terminal monitor attributes - addition
@ 2010-03-14 20:41 Shahar Havivi
2010-03-31 16:42 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Shahar Havivi @ 2010-03-14 20:41 UTC (permalink / raw)
To: qemu-devel
Patch 2d753894c7553d6a05e8fdbed5f4704398919a35 was missing this check,
when running monitor as /dev/tty and other serial device, i.e:
qemu -monitor /dev/tty -serial /dev/pts/1
Without this patch any serial device will override the monitor stored
attributes. (monitor is called in main() before any serial device).
Signed-off-by: Shahar Havivi <shaharh@redhat.com>
---
qemu-char.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 0e25ef3..4bf1e82 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1002,7 +1002,9 @@ static void tty_serial_init(int fd, int speed,
speed, parity, data_bits, stop_bits);
#endif
tcgetattr (fd, &tty);
- oldtty = tty;
+ if (!term_atexit_done) {
+ oldtty = tty;
+ }
#define check_speed(val) if (speed <= val) { spd = B##val; break; }
speed = speed * 10 / 11;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Restore terminal monitor attributes - addition
2010-03-14 20:41 [Qemu-devel] [PATCH] Restore terminal monitor attributes - addition Shahar Havivi
@ 2010-03-31 16:42 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-03-31 16:42 UTC (permalink / raw)
To: Shahar Havivi; +Cc: qemu-devel
On 03/14/2010 03:41 PM, Shahar Havivi wrote:
> Patch 2d753894c7553d6a05e8fdbed5f4704398919a35 was missing this check,
> when running monitor as /dev/tty and other serial device, i.e:
> qemu -monitor /dev/tty -serial /dev/pts/1
>
> Without this patch any serial device will override the monitor stored
> attributes. (monitor is called in main() before any serial device).
>
> Signed-off-by: Shahar Havivi<shaharh@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-char.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 0e25ef3..4bf1e82 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1002,7 +1002,9 @@ static void tty_serial_init(int fd, int speed,
> speed, parity, data_bits, stop_bits);
> #endif
> tcgetattr (fd,&tty);
> - oldtty = tty;
> + if (!term_atexit_done) {
> + oldtty = tty;
> + }
>
> #define check_speed(val) if (speed<= val) { spd = B##val; break; }
> speed = speed * 10 / 11;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-31 16:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-14 20:41 [Qemu-devel] [PATCH] Restore terminal monitor attributes - addition Shahar Havivi
2010-03-31 16:42 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).