From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nx1OY-0002Xd-OP for qemu-devel@nongnu.org; Wed, 31 Mar 2010 13:07:58 -0400 Received: from [140.186.70.92] (port=47257 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nx1OX-0002Wk-BC for qemu-devel@nongnu.org; Wed, 31 Mar 2010 13:07:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nx1OV-0000BK-8p for qemu-devel@nongnu.org; Wed, 31 Mar 2010 13:07:57 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:44213) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nx1OV-0000B8-4L for qemu-devel@nongnu.org; Wed, 31 Mar 2010 13:07:55 -0400 Received: by pwi6 with SMTP id 6so311051pwi.4 for ; Wed, 31 Mar 2010 10:07:54 -0700 (PDT) Message-ID: <4BB38167.4040409@codemonkey.ws> Date: Wed, 31 Mar 2010 12:07:51 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Remove magic numbers for VNC message IDs from code References: <1270053957-25898-1-git-send-email-berrange@redhat.com> In-Reply-To: <1270053957-25898-1-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org On 03/31/2010 11:45 AM, Daniel P. Berrange wrote: > diff --git a/vnc.h b/vnc.h > index 0a7487b..8752de0 100644 > --- a/vnc.h > +++ b/vnc.h > @@ -276,6 +276,57 @@ enum { > #define VNC_FEATURE_COPYRECT_MASK (1<< VNC_FEATURE_COPYRECT) > > > +/* Client -> Server message IDs */ > +#define VNC_MSG_CLIENT_SET_PIXEL_FORMAT 0 > +#define VNC_MSG_CLIENT_SET_ENCODINGS 2 > +#define VNC_MSG_CLIENT_FRAMEBUFFER_UPDATE_REQUEST 3 > +#define VNC_MSG_CLIENT_KEY_EVENT 4 > +#define VNC_MSG_CLIENT_POINTER_EVENT 5 > +#define VNC_MSG_CLIENT_CUT_TEXT 6 > +#define VNC_MSG_CLIENT_VMWARE_0 127 > +#define VNC_MSG_CLIENT_CALL_CONTROL 249 > +#define VNC_MSG_CLIENT_XVP 250 > +#define VNC_MSG_CLIENT_SET_DESKTOP_SIZE 251 > +#define VNC_MSG_CLIENT_TIGHT 252 > +#define VNC_MSG_CLIENT_GII 253 > +#define VNC_MSG_CLIENT_VMWARE_1 254 > +#define VNC_MSG_CLIENT_ALIGUORI 255 > + > +/* Server -> Client message IDs */ > +#define VNC_MSG_SERVER_FRAMEBUFFER_UPDATE 0 > +#define VNC_MSG_SERVER_SET_COLOUR_MAP_ENTRIES 1 > +#define VNC_MSG_SERVER_BELL 2 > +#define VNC_MSG_SERVER_CUT_TEXT 3 > +#define VNC_MSG_SERVER_VMWARE_0 127 > +#define VNC_MSG_SERVER_CALL_CONTROL 249 > +#define VNC_MSG_SERVER_XVP 250 > +#define VNC_MSG_SERVER_TIGHT 252 > +#define VNC_MSG_SERVER_GII 253 > +#define VNC_MSG_SERVER_VMWARE_1 254 > +#define VNC_MSG_SERVER_ALIGUORI 255 > + > + > + > +/* Aliguori client -> server message IDs */ > +#define VNC_MSG_CLIENT_ALIGUORI_EXT_KEY_EVENT 0 > +#define VNC_MSG_CLIENT_ALIGUORI_AUDIO 1 > + > +/* Aliguori server -> client message IDs */ > +#define VNC_MSG_SERVER_ALIGUORI_AUDIO 1 > + > + > + > +/* Aliguori client -> server audio message IDs */ > +#define VNC_MSG_CLIENT_ALIGUORI_AUDIO_ENABLE 0 > +#define VNC_MSG_CLIENT_ALIGUORI_AUDIO_DISABLE 1 > +#define VNC_MSG_CLIENT_ALIGUORI_AUDIO_SET_FORMAT 2 > + > +/* Aliguori server -> client audio message IDs */ > +#define VNC_MSG_SERVER_ALIGUORI_AUDIO_END 0 > +#define VNC_MSG_SERVER_ALIGUORI_AUDIO_BEGIN 1 > +#define VNC_MSG_SERVER_ALIGUORI_AUDIO_DATA 2 > Nice patch, but let's s/aliguori/qemu/. Regards, Anthony Liguori > + > /***************************************************************************** > * > * Internal APIs >