From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nx3Zv-0000Zm-Hq
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:27:51 -0400
Received: from [140.186.70.92] (port=46840 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nx3Zt-0000WL-W9
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nx3Zs-0007JJ-55
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:27:49 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:45247)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nx3Zr-0007Iw-T8
	for qemu-devel@nongnu.org; Wed, 31 Mar 2010 15:27:48 -0400
Received: by pwi6 with SMTP id 6so447756pwi.4
	for <qemu-devel@nongnu.org>; Wed, 31 Mar 2010 12:27:46 -0700 (PDT)
Message-ID: <4BB3A230.4080606@codemonkey.ws>
Date: Wed, 31 Mar 2010 14:27:44 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 7/7] Refactor target specific handling,
	compile vl.c only once
References: <f43fc5581003271511s7f7ab89ew847ea5a33b7ed2dc@mail.gmail.com>	
	<4BB397A1.2000508@codemonkey.ws>
	<r2of43fc5581003311219x1152c2cbz6c718a1528fff7d9@mail.gmail.com>
In-Reply-To: <r2of43fc5581003311219x1152c2cbz6c718a1528fff7d9@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 03/31/2010 02:19 PM, Blue Swirl wrote:
> On 3/31/10, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>> On 03/27/2010 05:11 PM, Blue Swirl wrote:
>>
>>      
>>> Move target specific functions and RAM handling to arch_init.c.
>>>
>>> Add a flag to QEMUOptions structure to indicate for which
>>> architectures the option is allowed, check the flag
>>> in run time and remove conditional code in option handling.
>>>
>>> Now that no target dependencies remain, compile vl.c only once
>>> for all targets.
>>>
>>> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
>>>
>>>
>>>        
>>   This causes -enable-kvm to seg fault.
>>      
> Variable kvm_state is used but it has not been initialized. This is
> because kvm_init is not called. And this happens because CONFIG_KVM is
> not set by config.h when included from vl.c.
>    

I spoke too soon before.  A lot of code depends on if (kvm_enabled()) 
going to 0 so it's a bigger refactoring to fix this once you start 
compiling targets that !defined(CONFIG_KVM)

Regards,

Anthony Liguori