From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxSRf-0005Y0-Jq for qemu-devel@nongnu.org; Thu, 01 Apr 2010 18:00:59 -0400 Received: from [140.186.70.92] (port=60976 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxSRe-0005Xl-DM for qemu-devel@nongnu.org; Thu, 01 Apr 2010 18:00:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxSRb-0004Xd-1k for qemu-devel@nongnu.org; Thu, 01 Apr 2010 18:00:58 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:64959) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxSRa-0004XX-T5 for qemu-devel@nongnu.org; Thu, 01 Apr 2010 18:00:54 -0400 Received: by gwj18 with SMTP id 18so290476gwj.4 for ; Thu, 01 Apr 2010 15:00:54 -0700 (PDT) Message-ID: <4BB51793.7060607@codemonkey.ws> Date: Thu, 01 Apr 2010 17:00:51 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] win32: Fix compiler errors from u_int64_t References: <1270158985-13119-1-git-send-email-weil@mail.berlios.de> In-Reply-To: <1270158985-13119-1-git-send-email-weil@mail.berlios.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers , "Michael S. Tsirkin" On 04/01/2010 04:56 PM, Stefan Weil wrote: > u_int64_t raises compiler error messages: > > CC libhw32/virtio.o > /qemu/ar7/hw/virtio.c: In function ‘virtio_queue_get_avail_size’: > /qemu/ar7/hw/virtio.c:776: error: ‘u_int64_t’ undeclared (first use in this function) > /qemu/ar7/hw/virtio.c:776: error: (Each undeclared identifier is reported only once > /qemu/ar7/hw/virtio.c:776: error: for each function it appears in.) > > Replacing u_int64_t by uint64_t helps. > Curious. What platform/gcc are you on? Applied. Thanks. Regards, Anthony Liguori > Cc: Michael S. Tsirkin > Cc: Anthony Liguori > Signed-off-by: Stefan Weil > --- > hw/vhost.c | 6 +++--- > hw/virtio.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/vhost.c b/hw/vhost.c > index 1e5bc69..ad2f98a 100644 > --- a/hw/vhost.c > +++ b/hw/vhost.c > @@ -357,9 +357,9 @@ static int vhost_virtqueue_set_addr(struct vhost_dev *dev, > { > struct vhost_vring_addr addr = { > .index = idx, > - .desc_user_addr = (u_int64_t)(unsigned long)vq->desc, > - .avail_user_addr = (u_int64_t)(unsigned long)vq->avail, > - .used_user_addr = (u_int64_t)(unsigned long)vq->used, > + .desc_user_addr = (uint64_t)(unsigned long)vq->desc, > + .avail_user_addr = (uint64_t)(unsigned long)vq->avail, > + .used_user_addr = (uint64_t)(unsigned long)vq->used, > .log_guest_addr = vq->used_phys, > .flags = enable_log ? (1<< VHOST_VRING_F_LOG) : 0, > }; > diff --git a/hw/virtio.c b/hw/virtio.c > index f54129f..e7657ae 100644 > --- a/hw/virtio.c > +++ b/hw/virtio.c > @@ -773,7 +773,7 @@ target_phys_addr_t virtio_queue_get_desc_size(VirtIODevice *vdev, int n) > target_phys_addr_t virtio_queue_get_avail_size(VirtIODevice *vdev, int n) > { > return offsetof(VRingAvail, ring) + > - sizeof(u_int64_t) * vdev->vq[n].vring.num; > + sizeof(uint64_t) * vdev->vq[n].vring.num; > } > > target_phys_addr_t virtio_queue_get_used_size(VirtIODevice *vdev, int n) >