From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NxjOT-0005QZ-2c
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:06:49 -0400
Received: from [140.186.70.92] (port=44467 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NxjOR-0005Og-Ox
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:06:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1NxjOQ-0003sU-2h
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:06:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9667)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1NxjOP-0003sL-OV
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:06:46 -0400
Message-ID: <4BB61610.40106@redhat.com>
Date: Fri, 02 Apr 2010 18:06:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are
	compiled once
References: <1270219540-30027-1-git-send-email-pbonzini@redhat.com>	
	<4BB60BB9.2050301@codemonkey.ws> <4BB610A7.8010006@redhat.com>
	<m2kf43fc5581004020905ye50f1213ve4d5b0ab4159a6d4@mail.gmail.com>
In-Reply-To: <m2kf43fc5581004020905ye50f1213ve4d5b0ab4159a6d4@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org


>>   qemu-kvm.h references CPUState and includes cpu.h, so with the latest
>> changes all files that include qemu-kvm.h break, even if they don't require
>> qemu-kvm.h.  With this patch they instead get the opaque definition via
>> hw/hw.h (which includes cpu-common.h), and qemu-kvm.h can avoid including
>> cpu.h.
>
> This is why I added #ifndef NEED_CPU_H to kvm.h.

Yes, but adding NEED_CPU_H everywhere is just as bad, or worse.

>>   Another example is the new apic.h file created by Blue Swirl.  It
>> references CPUState.  It includes apic_get_irq_delivered, so I placed
>> apic_set_irq_delivered there too.  But apic_set_irq_delivered is used by
>> i8259.c which is compiled once.
>
> But i8259.c is compiled per target, grep Makefile.target?

Hmm, that was something else, but apic.h was it. :-)

Paolo