From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once
Date: Fri, 02 Apr 2010 18:43:02 +0200 [thread overview]
Message-ID: <4BB61E96.90906@redhat.com> (raw)
In-Reply-To: <4BB61A21.20008@codemonkey.ws>
On 04/02/2010 06:24 PM, Anthony Liguori wrote:
>
> I'd rather things be compiled per-target than adding a bunch of crud
> everywhere.
Well, this patch in particular removes more lines than it adds. :-P
Anyway---me too, given how hairy it's coming out. Maybe (or without
maybe) this work should have been done on a branch.
> Wouldn't it be easier to split up qemu-kvm.h into qemu-kvm-cpu.h and add
> the later include where it's needed (which should be very few places)?
I won't have time to do this if you prefer that, I guess I'll have to
leave it to Marcelo and Avi.
Paolo
next prev parent reply other threads:[~2010-04-02 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 14:45 [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once Paolo Bonzini
2010-04-02 15:22 ` Anthony Liguori
2010-04-02 15:43 ` Paolo Bonzini
2010-04-02 16:05 ` Blue Swirl
2010-04-02 16:06 ` Paolo Bonzini
2010-04-02 16:18 ` Blue Swirl
2010-04-02 16:24 ` Anthony Liguori
2010-04-02 16:43 ` Paolo Bonzini [this message]
2010-04-02 17:36 ` Anthony Liguori
2010-04-02 17:46 ` Paolo Bonzini
2010-04-02 17:49 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB61E96.90906@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).