From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nxke9-0007jG-PN for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:27:05 -0400 Received: from [140.186.70.92] (port=49568 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nxke8-0007iL-4n for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:27:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nxke5-0003n5-Co for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:27:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27285) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nxke5-0003my-4C for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:27:01 -0400 Message-ID: <4BB61E96.90906@redhat.com> Date: Fri, 02 Apr 2010 18:43:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once References: <1270219540-30027-1-git-send-email-pbonzini@redhat.com> <4BB60BB9.2050301@codemonkey.ws> <4BB610A7.8010006@redhat.com> <4BB61A21.20008@codemonkey.ws> In-Reply-To: <4BB61A21.20008@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 04/02/2010 06:24 PM, Anthony Liguori wrote: > > I'd rather things be compiled per-target than adding a bunch of crud > everywhere. Well, this patch in particular removes more lines than it adds. :-P Anyway---me too, given how hairy it's coming out. Maybe (or without maybe) this work should have been done on a branch. > Wouldn't it be easier to split up qemu-kvm.h into qemu-kvm-cpu.h and add > the later include where it's needed (which should be very few places)? I won't have time to do this if you prefer that, I guess I'll have to leave it to Marcelo and Avi. Paolo