From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxk2I-0004EP-HU
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:47:58 -0400
Received: from [140.186.70.92] (port=52020 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxk2H-0004CO-Dm
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:47:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Nxk2G-0007dK-4W
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:47:57 -0400
Received: from mail-ew0-f227.google.com ([209.85.219.227]:62453)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Nxk2F-0007d6-Rl
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:47:56 -0400
Received: by ewy27 with SMTP id 27so634740ewy.10
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 09:47:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4BB61FB7.5040509@redhat.com>
Date: Fri, 02 Apr 2010 18:47:51 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <v2xf43fc5581004020846y1c0558b5m6d948a9ed59c7a82@mail.gmail.com>	<4BB61A74.9080304@codemonkey.ws>
	<u2zf43fc5581004020933n8007dee0s1f24a0508cc41887@mail.gmail.com>
In-Reply-To: <u2zf43fc5581004020933n8007dee0s1f24a0508cc41887@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] Make kvm_enabled unavailable to
	non-target devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>


>>> +#pragma GCC poison kvm_allowed
>>> +#pragma GCC poison kvm_enabled
>>
>>   kvm_enabled() is a macro.  I dont' think this poison pragma is actually
>> meaningful.
>
> I'm not familiar with poison pragmas, but actually poisoning only
> kvm_allowed didn't work.

Indeed, macro expansions are explicitly allowed to use poisoned 
identifiers (and on the contrary macro names count towards poisoning 
errors).

IMO kvm_allowed should be left unpoisoned.

Paolo