From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NxkCO-0006vq-87
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:58:24 -0400
Received: from [140.186.70.92] (port=43534 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NxkCG-0006tK-2u
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:58:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1NxkBt-0000Hc-UQ
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:57:55 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:41795)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1NxkBt-0000HM-Ps
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 12:57:53 -0400
Received: by pvc21 with SMTP id 21so939852pvc.4
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 09:57:52 -0700 (PDT)
Message-ID: <4BB6220D.7050902@codemonkey.ws>
Date: Fri, 02 Apr 2010 11:57:49 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <v2xf43fc5581004020846y1c0558b5m6d948a9ed59c7a82@mail.gmail.com>	<4BB61A74.9080304@codemonkey.ws>
	<u2zf43fc5581004020933n8007dee0s1f24a0508cc41887@mail.gmail.com>
	<4BB61FB7.5040509@redhat.com>
In-Reply-To: <4BB61FB7.5040509@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] Make kvm_enabled unavailable to
	non-target devices
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 04/02/2010 11:47 AM, Paolo Bonzini wrote:
>
>>>> +#pragma GCC poison kvm_allowed
>>>> +#pragma GCC poison kvm_enabled
>>>
>>>   kvm_enabled() is a macro.  I dont' think this poison pragma is 
>>> actually
>>> meaningful.
>>
>> I'm not familiar with poison pragmas, but actually poisoning only
>> kvm_allowed didn't work.
>
> Indeed, macro expansions are explicitly allowed to use poisoned 
> identifiers (and on the contrary macro names count towards poisoning 
> errors).
>
> IMO kvm_allowed should be left unpoisoned.

Interesting, thanks.

Regards,

Anthony Liguori

> Paolo