From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxkke-0001uS-6F
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:33:48 -0400
Received: from [140.186.70.92] (port=51300 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxkkc-0001tk-PC
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:33:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1Nxkka-0004R6-1E
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:33:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33384)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1NxkkZ-0004Qm-QA
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:33:44 -0400
Message-ID: <4BB62A74.6090109@redhat.com>
Date: Fri, 02 Apr 2010 19:33:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <p2nf43fc5581004020846j43d3ea6bt8cb9955a2b1db0b@mail.gmail.com>	
	<1270227919-31031-1-git-send-email-pbonzini@redhat.com>
	<z2gf43fc5581004021029j56b6b220w5a11f0b218ae7e2e@mail.gmail.com>
In-Reply-To: <z2gf43fc5581004021029j56b6b220w5a11f0b218ae7e2e@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if
	!CONFIG_KVM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 04/02/2010 07:29 PM, Blue Swirl wrote:
> Could you stub also kvm_init?

It is stubbed, but it returns ENOSYS:

  +int kvm_init(int smp_cpus)
  +{
  +    return -ENOSYS;
  +}
  +

and in fact I'm relying this to remove this:

  if (!(kvm_available())) {
      printf("Option %s not supported for this target\n", popt->name);
      exit(1);
  }

and instead looking for an error when I call kvm_init.  I don't see why 
kvm_init should be called if not passing -enable-kvm (which is kvm_allowed).

> Then this part would be simpler because
> you can call unconditionally kvm_init. I guess there would be no need
> to export kvm_allowed for !CONFIG_KVM case.

I don't understand what you mean.  If this doesn't clarify enough, feel 
free to pick up the patch and tweak it; I'm not going to spend much time 
on QEMU for a while.

Paolo