From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxknc-00033h-RR
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:36:52 -0400
Received: from [140.186.70.92] (port=53236 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxknb-00032c-DG
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:36:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1NxknZ-0004gw-Fx
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:36:51 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:57035)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1NxknZ-0004gq-Aj
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:36:49 -0400
Received: by pwi6 with SMTP id 6so1777024pwi.4
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 10:36:48 -0700 (PDT)
Message-ID: <4BB62B2D.2020403@codemonkey.ws>
Date: Fri, 02 Apr 2010 12:36:45 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are
	compiled once
References: <1270219540-30027-1-git-send-email-pbonzini@redhat.com>
	<4BB60BB9.2050301@codemonkey.ws> <4BB610A7.8010006@redhat.com>
	<4BB61A21.20008@codemonkey.ws> <4BB61E96.90906@redhat.com>
In-Reply-To: <4BB61E96.90906@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 04/02/2010 11:43 AM, Paolo Bonzini wrote:
> On 04/02/2010 06:24 PM, Anthony Liguori wrote:
>>
>> I'd rather things be compiled per-target than adding a bunch of crud
>> everywhere.
>
> Well, this patch in particular removes more lines than it adds. :-P
>
> Anyway---me too, given how hairy it's coming out.  Maybe (or without 
> maybe) this work should have been done on a branch.

What files need to be compiled per-target to fix qemu-kvm?

Regards,

Anthony Liguori

>> Wouldn't it be easier to split up qemu-kvm.h into qemu-kvm-cpu.h and add
>> the later include where it's needed (which should be very few places)?
>
> I won't have time to do this if you prefer that, I guess I'll have to 
> leave it to Marcelo and Avi.
>
> Paolo