From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once
Date: Fri, 02 Apr 2010 12:49:30 -0500 [thread overview]
Message-ID: <4BB62E2A.90209@codemonkey.ws> (raw)
In-Reply-To: <4BB62D92.7040707@redhat.com>
On 04/02/2010 12:46 PM, Paolo Bonzini wrote:
> On 04/02/2010 07:36 PM, Anthony Liguori wrote:
>> On 04/02/2010 11:43 AM, Paolo Bonzini wrote:
>>> On 04/02/2010 06:24 PM, Anthony Liguori wrote:
>>>>
>>>> I'd rather things be compiled per-target than adding a bunch of crud
>>>> everywhere.
>>>
>>> Well, this patch in particular removes more lines than it adds. :-P
>>>
>>> Anyway---me too, given how hairy it's coming out. Maybe (or without
>>> maybe) this work should have been done on a branch.
>>
>> What files need to be compiled per-target to fix qemu-kvm?
>
> With this patch, pci.o/i8254.o/acpi.o. Without, also pcspk.o and
> acpi.o then I stopped.
i8254.o has to be a bug. There should be no reason to include
qemu-kvm.h there. Likewise with acpi.o and pcspk.o.
Regards,
Anthony Liguori
> Paolo
prev parent reply other threads:[~2010-04-02 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 14:45 [Qemu-devel] [PATCH] provide opaque CPUState to files that are compiled once Paolo Bonzini
2010-04-02 15:22 ` Anthony Liguori
2010-04-02 15:43 ` Paolo Bonzini
2010-04-02 16:05 ` Blue Swirl
2010-04-02 16:06 ` Paolo Bonzini
2010-04-02 16:18 ` Blue Swirl
2010-04-02 16:24 ` Anthony Liguori
2010-04-02 16:43 ` Paolo Bonzini
2010-04-02 17:36 ` Anthony Liguori
2010-04-02 17:46 ` Paolo Bonzini
2010-04-02 17:49 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB62E2A.90209@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).