From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nxkzx-0005z5-Ch
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:49:37 -0400
Received: from [140.186.70.92] (port=34446 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nxkzw-0005yq-6j
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:49:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nxkzu-0005nN-JV
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:49:36 -0400
Received: from mail-pv0-f173.google.com ([74.125.83.173]:41727)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1Nxkzu-0005nC-C3
	for qemu-devel@nongnu.org; Fri, 02 Apr 2010 13:49:34 -0400
Received: by pvc21 with SMTP id 21so959078pvc.4
	for <qemu-devel@nongnu.org>; Fri, 02 Apr 2010 10:49:33 -0700 (PDT)
Message-ID: <4BB62E2A.90209@codemonkey.ws>
Date: Fri, 02 Apr 2010 12:49:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] provide opaque CPUState to files that are
	compiled once
References: <1270219540-30027-1-git-send-email-pbonzini@redhat.com>
	<4BB60BB9.2050301@codemonkey.ws> <4BB610A7.8010006@redhat.com>
	<4BB61A21.20008@codemonkey.ws> <4BB61E96.90906@redhat.com>
	<4BB62B2D.2020403@codemonkey.ws> <4BB62D92.7040707@redhat.com>
In-Reply-To: <4BB62D92.7040707@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 04/02/2010 12:46 PM, Paolo Bonzini wrote:
> On 04/02/2010 07:36 PM, Anthony Liguori wrote:
>> On 04/02/2010 11:43 AM, Paolo Bonzini wrote:
>>> On 04/02/2010 06:24 PM, Anthony Liguori wrote:
>>>>
>>>> I'd rather things be compiled per-target than adding a bunch of crud
>>>> everywhere.
>>>
>>> Well, this patch in particular removes more lines than it adds. :-P
>>>
>>> Anyway---me too, given how hairy it's coming out. Maybe (or without
>>> maybe) this work should have been done on a branch.
>>
>> What files need to be compiled per-target to fix qemu-kvm?
>
> With this patch, pci.o/i8254.o/acpi.o.  Without, also pcspk.o and 
> acpi.o then I stopped.

i8254.o has to be a bug.  There should be no reason to include 
qemu-kvm.h there.  Likewise with acpi.o and pcspk.o.

Regards,

Anthony Liguori

> Paolo