From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM
Date: Sun, 04 Apr 2010 09:12:04 +0200 [thread overview]
Message-ID: <4BB83BC4.5040005@redhat.com> (raw)
In-Reply-To: <k2lf43fc5581004030207i1b8a80den9fe7439bfa72f771@mail.gmail.com>
On 04/03/2010 11:07 AM, Blue Swirl wrote:
> On 4/3/10, Paolo Bonzini<pbonzini@redhat.com> wrote:
>> On 04/02/2010 09:04 PM, Blue Swirl wrote:
>>
>>> -int kvm_init(int smp_cpus);
>>>
>>
>> I had missed this; I don't see a particular reason to move this out of
>> kvm.h. Anyway I don't feel strongly about this.
>
> The reason is to avoid including kvm.h by vl.c.
But that's not a problem, kvm.h can be included by compiled-once files;
that was the reason to introduce the stubs in the first place. kvm_*
should be declared in kvm.h.
Paolo
next prev parent reply other threads:[~2010-04-04 7:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 15:46 [Qemu-devel] [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once Blue Swirl
2010-04-02 17:05 ` [Qemu-devel] [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM Paolo Bonzini
2010-04-02 17:29 ` [Qemu-devel] " Blue Swirl
2010-04-02 17:33 ` Paolo Bonzini
2010-04-02 18:17 ` Blue Swirl
2010-04-02 18:33 ` Paolo Bonzini
2010-04-02 19:04 ` Blue Swirl
2010-04-03 9:04 ` Paolo Bonzini
2010-04-03 9:07 ` Blue Swirl
2010-04-04 7:12 ` Paolo Bonzini [this message]
2010-04-04 7:25 ` Blue Swirl
2010-04-04 18:13 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB83BC4.5040005@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).