From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyK0I-0004Xo-QC for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:12:18 -0400 Received: from [140.186.70.92] (port=36367 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyK0G-0004Wy-5j for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:12:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyK0B-0007Oe-51 for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:12:16 -0400 Received: from mail-bw0-f218.google.com ([209.85.218.218]:49874) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyK0A-0007Nr-Oy for qemu-devel@nongnu.org; Sun, 04 Apr 2010 03:12:11 -0400 Received: by bwz10 with SMTP id 10so3925202bwz.2 for ; Sun, 04 Apr 2010 00:12:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4BB83BC4.5040005@redhat.com> Date: Sun, 04 Apr 2010 09:12:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1270227919-31031-1-git-send-email-pbonzini@redhat.com> <4BB62A74.6090109@redhat.com> <4BB63869.9090301@redhat.com> <4BB70490.6000506@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if !CONFIG_KVM List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 04/03/2010 11:07 AM, Blue Swirl wrote: > On 4/3/10, Paolo Bonzini wrote: >> On 04/02/2010 09:04 PM, Blue Swirl wrote: >> >>> -int kvm_init(int smp_cpus); >>> >> >> I had missed this; I don't see a particular reason to move this out of >> kvm.h. Anyway I don't feel strongly about this. > > The reason is to avoid including kvm.h by vl.c. But that's not a problem, kvm.h can be included by compiled-once files; that was the reason to introduce the stubs in the first place. kvm_* should be declared in kvm.h. Paolo