From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NyUKE-0000rN-Ky
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 14:13:34 -0400
Received: from [140.186.70.92] (port=59051 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NyUKC-0000om-NN
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 14:13:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1NyUKA-0003U4-EU
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 14:13:32 -0400
Received: from mail-bw0-f218.google.com ([209.85.218.218]:40918)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1NyUK9-0003Tg-UP
	for qemu-devel@nongnu.org; Sun, 04 Apr 2010 14:13:30 -0400
Received: by bwz10 with SMTP id 10so4132937bwz.2
	for <qemu-devel@nongnu.org>; Sun, 04 Apr 2010 11:13:29 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4BB8D6C6.8010403@redhat.com>
Date: Sun, 04 Apr 2010 20:13:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <p2nf43fc5581004020846j43d3ea6bt8cb9955a2b1db0b@mail.gmail.com>	<1270227919-31031-1-git-send-email-pbonzini@redhat.com>	<z2gf43fc5581004021029j56b6b220w5a11f0b218ae7e2e@mail.gmail.com>	<4BB62A74.6090109@redhat.com>	<y2sf43fc5581004021117nb2cfdcccr17b3a4f4acd8c0f7@mail.gmail.com>	<4BB63869.9090301@redhat.com>	<w2yf43fc5581004021204w62027b44m2d2ba98d94d2dbe0@mail.gmail.com>	<4BB70490.6000506@redhat.com>	<k2lf43fc5581004030207i1b8a80den9fe7439bfa72f771@mail.gmail.com>	<4BB83BC4.5040005@redhat.com>
	<u2tf43fc5581004040025r8ed5cc93xca1ad94c662bdfcc@mail.gmail.com>
In-Reply-To: <u2tf43fc5581004040025r8ed5cc93xca1ad94c662bdfcc@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] provide a stub version of kvm-all.c if
	!CONFIG_KVM
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org


>>> The reason is to avoid including kvm.h by vl.c.
>>
>>   But that's not a problem, kvm.h can be included by compiled-once files;
>> that was the reason to introduce the stubs in the first place.  kvm_* should
>> be declared in kvm.h.
>
> That can't be safe because CONFIG_KVM will not be defined for files
> compiled once. So even with the stubs, those files would use inlined
> stubs where they shouldn't.

1) Stubs are linked, not inlined.

2) vl.c does not use kvm_enabled

3) even if it did, it is defined like this after my patch:

#if defined CONFIG_KVM || !defined NEED_CPU_H
#define kvm_enabled() (kvm_allowed)
#else
#define kvm_enabled() (0)
#endif

Paolo