From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nz4BI-0004UZ-DZ
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 04:30:44 -0400
Received: from [140.186.70.92] (port=35464 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nz4BH-0004Ty-3Z
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 04:30:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1Nz4BF-00013O-Rd
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 04:30:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54928)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1Nz3TA-0001Z9-M5
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 03:45:14 -0400
Message-ID: <4BBAE67C.8080008@redhat.com>
Date: Tue, 06 Apr 2010 09:45:00 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1270471538-31275-1-git-send-email-amit.shah@redhat.com>
	<1270471538-31275-2-git-send-email-amit.shah@redhat.com>
	<1270471538-31275-3-git-send-email-amit.shah@redhat.com>
	<1270471538-31275-4-git-send-email-amit.shah@redhat.com>
	<1270471538-31275-5-git-send-email-amit.shah@redhat.com>
	<1270471538-31275-6-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1270471538-31275-6-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/5] virtio-console: Throttle
 virtio-serial-bus if we can't consume any more guest data
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>

   Hi,

> +/* Callback function when the timer expires */
> +static void unthrottle_port(VirtConsole *vcon)
> +{

Why a timer?

qemu_set_fd_handler(fd, NULL, write_callback, opaque) ?

cheers,
   Gerd