From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzPIG-0004FD-IN
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 03:03:20 -0400
Received: from [140.186.70.92] (port=41401 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzPHs-00044X-4f
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 03:03:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1NzPHY-0005fq-Df
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 03:02:55 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:53464)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1NzPHV-0005eh-84
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 03:02:33 -0400
Message-ID: <4BBC2DEE.1050006@mail.berlios.de>
Date: Wed, 07 Apr 2010 09:02:06 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without
	EEPROM
References: <1270554249-24861-1-git-send-email-weil@mail.berlios.de>
	<1270554249-24861-7-git-send-email-weil@mail.berlios.de>
	<201004070200.23054.paul@codesourcery.com>
In-Reply-To: <201004070200.23054.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Paul Brook schrieb:
>> To emulate hardware without an EEPROM,
>> EEPROM_SIZE may be set to 0.
>
> If might, but it isn't.
>
> This patch introduces a condition that will never be false. Please
> don't do
> that. I consider code that is never used to be actively harmful. Any
> feature
> that requires the user hack the source may as well not exist. The only
> possible exception is debug output intended solely for qemu developers.
>
> If there's something worth noting for future reference then add a proper
> comment, if necessary marked as TODO/FIXME.
>
> Paul

In this case, it is code which is normally always used,
so maybe it is a little less harmful :-)

Anyway - Richard already gave a good feedback on the same topic.

His feedback convinced me that adding an eeprom size or model
property as a device option would be the better way to
support both developer needs (I want to make tests with
no eeprom) and user needs (normally, an eeprom is
available). The preprocessor #if would be replaced by
a normal C if.

I'll do this in a future patch.

Michael, I suggest either omitting this patch or adding a
TODO comment to the preprocessor #if like this:

#if EEPROM_SIZE > 0 /* TODO: add a new EEPROM property and use it here */

Regards,
Stefan