From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzUDs-0003R2-8g
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:19:08 -0400
Received: from [140.186.70.92] (port=60010 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzUDq-0003Qu-P1
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:19:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1NzUDp-0002Z6-Cr
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:19:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62128)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1NzUDp-0002YX-41
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:19:05 -0400
Message-ID: <4BBC7812.8080802@redhat.com>
Date: Wed, 07 Apr 2010 14:18:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release
	in	virtio_blk_handle_rw_error
References: <4BBC70E3.6010609@siemens.com> <20100407115738.GA12452@lst.de>
In-Reply-To: <20100407115738.GA12452@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

Am 07.04.2010 13:57, schrieb Christoph Hellwig:
> On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote:
>> virtio_blk_req_complete releases the request we dereference again for
>> bdrv_mon_event. Reorder both calls to fix this.
> 
> I think Kevin alreday sent a patch to use the local state variable
> which is still around.  Either way looks fine to me.

Yes, it's the same thing, so I won't pick this up for my block branch
even though Jan's fix looks fine, too.

Kevin