* [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
@ 2010-04-07 11:58 Christoph Hellwig
2010-04-07 12:38 ` Kevin Wolf
2010-04-10 0:22 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2010-04-07 11:58 UTC (permalink / raw)
To: qemu-devel
bdrv_open already takes care of this for us.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: qemu/block/raw-posix.c
===================================================================
--- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.573261199 +0200
+++ qemu/block/raw-posix.c 2010-04-07 13:50:25.180005926 +0200
@@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
s->open_flags |= O_RDWR;
} else {
s->open_flags |= O_RDONLY;
- bs->read_only = 1;
}
/* Use O_DSYNC for write-through caching, no flags for write-back caching,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
2010-04-07 11:58 [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only Christoph Hellwig
@ 2010-04-07 12:38 ` Kevin Wolf
2010-04-10 0:22 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2010-04-07 12:38 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
Am 07.04.2010 13:58, schrieb Christoph Hellwig:
> bdrv_open already takes care of this for us.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: qemu/block/raw-posix.c
> ===================================================================
> --- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.573261199 +0200
> +++ qemu/block/raw-posix.c 2010-04-07 13:50:25.180005926 +0200
> @@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
> s->open_flags |= O_RDWR;
> } else {
> s->open_flags |= O_RDONLY;
> - bs->read_only = 1;
> }
>
> /* Use O_DSYNC for write-through caching, no flags for write-back caching,
Acked-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
2010-04-07 11:58 [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only Christoph Hellwig
2010-04-07 12:38 ` Kevin Wolf
@ 2010-04-10 0:22 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-04-10 0:22 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
On Wed, Apr 07, 2010 at 01:58:06PM +0200, Christoph Hellwig wrote:
> bdrv_open already takes care of this for us.
Thanks, applied.
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: qemu/block/raw-posix.c
> ===================================================================
> --- qemu.orig/block/raw-posix.c 2010-04-07 13:50:16.573261199 +0200
> +++ qemu/block/raw-posix.c 2010-04-07 13:50:25.180005926 +0200
> @@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
> s->open_flags |= O_RDWR;
> } else {
> s->open_flags |= O_RDONLY;
> - bs->read_only = 1;
> }
>
> /* Use O_DSYNC for write-through caching, no flags for write-back caching,
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-10 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-07 11:58 [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only Christoph Hellwig
2010-04-07 12:38 ` Kevin Wolf
2010-04-10 0:22 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).