From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzUWr-0002oS-Bd
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:38:45 -0400
Received: from [140.186.70.92] (port=59902 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzUWo-0002ns-TI
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:38:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1NzUWn-0006Wc-G6
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:38:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43606)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1NzUWn-0006WL-8P
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:38:41 -0400
Message-ID: <4BBC7CAA.4000506@redhat.com>
Date: Wed, 07 Apr 2010 14:38:02 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] raw-posix: don't assign bs->read_only
References: <20100407115806.GC12452@lst.de>
In-Reply-To: <20100407115806.GC12452@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

Am 07.04.2010 13:58, schrieb Christoph Hellwig:
> bdrv_open already takes care of this for us.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: qemu/block/raw-posix.c
> ===================================================================
> --- qemu.orig/block/raw-posix.c	2010-04-07 13:50:16.573261199 +0200
> +++ qemu/block/raw-posix.c	2010-04-07 13:50:25.180005926 +0200
> @@ -142,7 +142,6 @@ static int raw_open_common(BlockDriverSt
>          s->open_flags |= O_RDWR;
>      } else {
>          s->open_flags |= O_RDONLY;
> -        bs->read_only = 1;
>      }
>  
>      /* Use O_DSYNC for write-through caching, no flags for write-back caching,

Acked-by: Kevin Wolf <kwolf@redhat.com>