qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Amit Shah <amit.shah@redhat.com>
Cc: waldi@debian.org, Carsten Otte <carsteno@de.ibm.com>,
	qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 3/6] Make char muxer more robust wrt small FIFOs
Date: Wed, 07 Apr 2010 16:32:04 +0200	[thread overview]
Message-ID: <4BBC9764.1080402@suse.de> (raw)
In-Reply-To: <20100405034021.GA7100@amit-x200.redhat.com>

Amit Shah wrote:
> On (Thu) Apr 01 2010 [18:42:38], Alexander Graf wrote:
>   
>> Virtio-Console can only process one character at a time.
>>     
>
> The host can process as many as you give it, depending on the buffer
> size exposed by the guest.
>
> On older guests (guest kernels w/o multiport support), the guest reads
> input from host, processes it and only then opens up another buffer for
> the host to write into.
>
> On newer guests (guest kernels that support multiport), the guest
> fills the entire vq so that host can send as many buffers as possible
> without getting throttled. I guess you're getting hit by this.
>   

Probably, yes.

>> Using it on S390
>> gave me strage "lags" where I got the character I pressed before when
>> pressing one. So I typed in "abc" and only received "a", then pressed "d"
>> but the guest received "b" and so on.
>>     
>
> This might be because qemu-char would not be able to send out 'b' while
> the guest still processes 'a' and has no free buffers to write out to.
> On seeing 'd', it flushes its queue.
>
> Can you try using a 2.6.34-rc3 kernel without this patch to see if
> things work fine?
>   

Hrm - would it actually matter? We need to have older guest kernels
working anyways. And my S390 LPAR doesn't exactly have a lot of disk
space, so compiling a kernel is anything but fun :-).


Alex

  reply	other threads:[~2010-04-07 14:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 16:42 [Qemu-devel] [PATCH 0/6] S390 April patch round Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 1/6] S390: Add stub for cpu_get_phys_page_debug Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 2/6] S390: Tell user why VM creation failed Alexander Graf
2010-04-01 16:42 ` [Qemu-devel] [PATCH 3/6] Make char muxer more robust wrt small FIFOs Alexander Graf
2010-04-05  3:40   ` Amit Shah
2010-04-07 14:32     ` Alexander Graf [this message]
2010-04-07 14:43       ` Amit Shah
2010-04-01 16:42 ` [Qemu-devel] [PATCH 4/6] Always notify consumers of char devices if they're open Alexander Graf
2010-04-05  3:43   ` Amit Shah
2010-04-09 20:09   ` Aurelien Jarno
2010-04-01 16:42 ` [Qemu-devel] [PATCH 5/6] [S390] Implement virtio reset Alexander Graf
2010-04-09 20:09   ` Aurelien Jarno
2010-04-01 16:42 ` [Qemu-devel] [PATCH 6/6] [S390] Add firmware code Alexander Graf
2010-04-01 21:18   ` [Qemu-devel] " Bastian Blank
2010-04-01 22:10     ` Alexander Graf
2010-04-09 20:17   ` [Qemu-devel] " Aurelien Jarno
2010-04-09 23:29     ` Alexander Graf
2010-04-10  0:00       ` Aurelien Jarno
2010-04-10  9:22         ` Alexander Graf
2010-04-10 15:03           ` Aurelien Jarno
2010-04-12  8:43     ` Carsten Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BBC9764.1080402@suse.de \
    --to=agraf@suse.de \
    --cc=amit.shah@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=carsteno@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=waldi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).