From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nzusi-00052D-Id for qemu-devel@nongnu.org; Thu, 08 Apr 2010 12:47:04 -0400 Received: from [140.186.70.92] (port=39325 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nzusf-0004zu-Ql for qemu-devel@nongnu.org; Thu, 08 Apr 2010 12:47:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nzuse-0002Mi-EM for qemu-devel@nongnu.org; Thu, 08 Apr 2010 12:47:01 -0400 Received: from are.twiddle.net ([75.149.56.221]:57572) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nzuse-0002MY-7C for qemu-devel@nongnu.org; Thu, 08 Apr 2010 12:47:00 -0400 Message-ID: <4BBE0882.4020703@twiddle.net> Date: Thu, 08 Apr 2010 09:46:58 -0700 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 06/18] tcg/arm: add defines for the allowed instructions set References: <1270662685-7379-1-git-send-email-aurelien@aurel32.net> <1270662685-7379-7-git-send-email-aurelien@aurel32.net> In-Reply-To: <1270662685-7379-7-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Andrzej Zaborowski , qemu-devel@nongnu.org On 04/07/2010 10:51 AM, Aurelien Jarno wrote: > +#if defined(__ARM_ARCH_5T__) || \ > + defined(__ARM_ARCH_5TE__) || \ > + defined(__ARM_ARCH_5TEJ__) || \ > + defined(__ARM_ARCH_6__) || \ > + defined(__ARM_ARCH_7A__) || \ > + defined(__ARM_ARCH_7__) > +# define USE_ARMV5_INSTRUCTIONS 1 > +#endif Wouldn't it be better to add a zero definition here so that you can use C if's and not ifdefs, so as to make sure that all code paths are semantically correct. It's very easy to introduce a typo in a code path that isn't used by a particular host's build. r~