From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0H3W-0001wP-7J
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 12:27:42 -0400
Received: from [140.186.70.92] (port=41141 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0H3S-0001ul-H5
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 12:27:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1O0H3P-000187-52
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 12:27:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48293)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <pbonzini@redhat.com>) id 1O0H3O-00017q-Ru
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 12:27:35 -0400
Message-ID: <4BBF5569.2080401@redhat.com>
Date: Fri, 09 Apr 2010 18:27:21 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1270765360-5008-1-git-send-email-thomas_ml@monjalon.net>
	<4BBECC72.5080803@redhat.com>
	<201004091731.25184.thomas_ml@monjalon.net>
In-Reply-To: <201004091731.25184.thomas_ml@monjalon.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] microblaze: fix build on Ubuntu Hardy
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Monjalon <thomas_ml@monjalon.net>
Cc: qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>

On 04/09/2010 05:31 PM, Thomas Monjalon wrote:
> Paolo Bonzini wrote:
>> On 04/09/2010 12:22 AM, Thomas Monjalon wrote:
>>> Using GCC-4.2.4-1ubuntu4, there were 3 warnings.
>>
>> The last two are correct, but what was the first error?  If it was a
>> shadowed declaration as it seems to be, the solution is to
>> s/fprintf/fprintf_func/ throughout print_insn_microblaze (for example).
>
> Paul, Paolo, you're right.
> Nice review !
>
> The error message is:
>
>      microblaze-dis.c:792: warning: unused variable 'fprintf'
>
> But the error message is bogus. It is a shadowed declaration.

... which is hidden because FORTIFY_SOURCE changes fprintf to 
fprintf_chk.  So you're fixing a bug too! :-)

Paolo